CCS-361: Redefinition of migration time maps #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudunSektnanNR
changed the base branch from
develop_old_BU250923
to
develop
Comment on lines
27
to
31
| co2_props[1:], | ||
| time_since_start[1:], | ||
| ): | ||
| above_threshold = co2.values > co2_threshold | ||
| diff_prop = co2.values - co2_props[0].values | ||
| above_threshold = np.abs(diff_prop) > co2_threshold |
There was a problem hiding this comment.
Looks good! Can probably change the docstring above ("Migration time is ...").
Do we want np.abs(diff_prop) or just diff_prop? With absolute value we will see all changes, positive and negative. With only diff_prop we will observe only positive changes. Which kind of aligns with the name of the script "migration time", that something has migrated somewhere (=> increased some property that shows this). But I think using np.abs() is fine. Pros and cons.
There was a problem hiding this comment.
Only positive changes it is! Also, docstring is changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.