Skip to content

ES module version #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ES module version #6

wants to merge 2 commits into from

Conversation

tirithen
Copy link

I need an ES module version of this package for a project. I simply created an esm.js copy of the CommonJS version.

I'm a bit unsure on how to setup a testing and linting so that both versions can co-exist without changeing the project structure too much, I'm all up for working on that if it sounds like a good idea if I can get some hints on which project structure you would like.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7a3dcf2 on tirithen:master into c9782fd on epoberezkin:master.

@abdonrd
Copy link

abdonrd commented Sep 25, 2019

@epoberezkin any news here? Thanks!

@tirithen
Copy link
Author

@abdonrd for now I use my pull request at https://github.com/tirithen/fast-json-stable-stringify directly in my package.json like this:

"fast-json-stable-stringify": "git+https://[email protected]/tirithen/fast-json-stable-stringify.git",

Importing/usage is identical, feel free to try that out if you want. :)

It would be even better if it was possible to get an ES6 version added directly into this repo. Lets hope that @epoberezkin can find the time.

@abdonrd
Copy link

abdonrd commented Oct 17, 2019

@tirithen I create a PR to support both cases: #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants