Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] Update rackup 2.1.0 → 2.2.0 (minor) #263

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Nov 9, 2024


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rackup (2.1.0 → 2.2.0) · Repo

Commits

See the full diff on Github. The new version differs by 15 commits:

↗️ rack (indirect, 3.0.9.1 → 3.1.8) · Repo · Changelog

Security Advisories 🚨

🚨 Rack ReDoS Vulnerability in HTTP Accept Headers Parsing

Summary

A Regular Expression Denial of Service (ReDoS) vulnerability exists in the Rack::Request::Helpers module when parsing HTTP Accept headers. This vulnerability can be exploited by an attacker sending specially crafted Accept-Encoding or Accept-Language headers, causing the server to spend excessive time processing the request and leading to a Denial of Service (DoS).

Details

The fix for GHSA-54rr-7fvw-6x8f was not applied to the main branch and thus while the issue was fixed for the Rack v3.0 release series, it was not fixed in the v3.1 release series until v3.1.5.

Release Notes

3.1.8 (from changelog)

Fixed

  • Resolve deprecation warnings about uri DEFAULT_PARSER. (#2249, @earlopain)

3.1.7 (from changelog)

Fixed

  • Do not remove escaped opening/closing quotes for content-disposition filenames. (#2229, @jeremyevans)
  • Fix encoding setting for non-binary IO-like objects in MockRequest#env_for. (#2227, @jeremyevans)
  • Rack::Response should not generate invalid content-length header. (#2219, @ioquatix)
  • Allow empty PATH_INFO. (#2214, @ioquatix)

3.1.6 (from changelog)

  • Fix several edge cases in Rack::Request#parse_http_accept_header's implementation. (#2226, @ioquatix)

3.1.5 (from changelog)

Security

3.1.4 (from changelog)

Fixed

  • Fix Rack::Lint matching some paths incorrectly as authority form. (#2220, @ioquatix)

3.1.2 (from changelog)

  • Rack::Response will take in to consideration chunked encoding responses (#2204, [@tenderlove])

3.1.1 (from changelog)

  • Oops! I shouldn't have shipped that

3.1.0 (from changelog)

Rack v3.1 is primarily a maintenance release that removes features deprecated in Rack v3.0. Alongside these removals, there are several improvements to the Rack SPEC, mainly focused on enhancing input and output handling. These changes aim to make Rack more efficient and align better with the requirements of server implementations and relevant HTTP specifications.

SPEC Changes

Added

  • Introduce Rack::Multipart::MissingInputError for improved handling of missing input in #parse_multipart. (#2018, @ioquatix)
  • Introduce module Rack::BadRequest which is included in multipart and query parser errors. (#2019, @ioquatix)
  • Add .mjs MIME type (#2057, @axilleas)
  • set_cookie_header utility now supports the partitioned cookie attribute. This is required by Chrome in some embedded contexts. (#2131, @flavio-b)
  • Introduce rack.early_hints for sending 103 Early Hints informational responses. (#1831, @casperisfine, @jeremyevans)

Changed

  • MIME type for JavaScript files (.js) changed from application/javascript to text/javascript (1bd0f15, @ioquatix)
  • Update MIME types associated to .ttf, .woff, .woff2 and .otf extensions to use mondern font/* types. (#2065, @davidstosik)
  • Rack::Utils.escape_html is now delegated to CGI.escapeHTML. ' is escaped to #39; instead of #x27;. (decimal vs hexadecimal) (#2099, @JunichiIto)
  • Clarify use of @buffered and only update content-length when Rack::Response#finish is invoked. (#2149, @ioquatix)

Deprecated

  • Deprecate automatic cache invalidation in Request#{GET,POST} (#2073, @jeremyevans)
  • Only cookie keys that are not valid according to the HTTP specifications are escaped. We are planning to deprecate this behaviour, so now a deprecation message will be emitted in this case. In the future, invalid cookie keys may not be accepted. (#2191, @ioquatix)
  • Rack::Logger is deprecated. (#2197, @ioquatix)
  • Add fallback lookup and deprecation warning for obsolete status symbols. (#2137, @wtn)

Removed

  • Remove deprecated Rack::Auth::Digest with no replacement. (#1966, @ioquatix)
  • Remove deprecated Rack::Cascade::NotFound with no replacement. (#1966, @ioquatix)
  • Remove deprecated Rack::Chunked with no replacement. (#1966, @ioquatix)
  • Remove deprecated Rack::File, use Rack::Files instead. (#1966, @ioquatix)
  • Remove deprecated Rack::QueryParser key_space_limit parameter with no replacement. (#1966, @ioquatix)
  • Remove deprecated Rack::Response#header, use Rack::Response#headers instead. (#1966, @ioquatix)
  • Remove deprecated cookie methods from Rack::Utils: add_cookie_to_header, make_delete_cookie_header, add_remove_cookie_to_header. (#1966, @ioquatix)
  • Remove deprecated Rack::Utils::HeaderHash. (#1966, @ioquatix)
  • Remove deprecated Rack::VERSION, Rack::VERSION_STRING, Rack.version, use Rack.release instead. (#1966, @ioquatix)
  • Remove non-standard status codes 306, 509, & 510 and update descriptions for 413, 422, & 451. (#2137, @wtn)
  • Remove any dependency on transfer-encoding: chunked. (#2195, @ioquatix)

Fixed

  • In Rack::Files, ignore the Range header if served file is 0 bytes. (#2159, [@zarqman])

3.0.11 (from changelog)

  • Backport #2062 to 3-0-stable: Do not allow BodyProxy to respond to to_str, make to_ary call close . (#2062, @jeremyevans)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

🗑️ webrick (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the dependencies Libraries depended upon label Nov 9, 2024
@depfu depfu bot requested a review from epistrephein as a code owner November 9, 2024 04:46
@epistrephein epistrephein merged commit 72a639a into main Nov 10, 2024
1 check passed
@epistrephein epistrephein deleted the depfu/update/rackup-2.2.0 branch November 10, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Libraries depended upon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant