-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #548: Refactor the getting started vignette #549
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
+ Coverage 95.59% 95.66% +0.07%
==========================================
Files 17 17
Lines 998 1015 +17
==========================================
+ Hits 954 971 +17
Misses 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a read of the code (self-review). Waiting on the rendered site for final checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The html looks good so I think this is good to go.
Description
This PR closes #548 #68 and #403 by refactoring the getting started vignette to:
In developing this PR I have explored the predict workflow and corrected the following issues:
I will open an issue for some thoughts on the current postprocess workflow as it feels like there are too many paths to take and some common tasks require to much work.
Checklist