Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #507: Add weighting support to marginal model class #509

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Jan 22, 2025

Description

This PR closes #507 by adding weighting support to the linelist method for the marginal model. This allows you to seamlessly use aggregate data for the marginal model. It is a component of #412.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@seabbs seabbs marked this pull request as ready for review January 28, 2025 11:13
Copy link
Contributor Author

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (self-review).

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (ceffa60) to head (6ddc7db).
Report is 651 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   94.09%   92.50%   -1.60%     
==========================================
  Files          15       16       +1     
  Lines         457      640     +183     
==========================================
+ Hits          430      592     +162     
- Misses         27       48      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs
Copy link
Contributor Author

seabbs commented Jan 28, 2025

coverage is a false positive from other parts of the package that are untouched here due to the git changes to reduce the repo size (monitoring this). CI failure is #487 and so also a false positive.

@seabbs seabbs merged commit e1a8fa0 into main Jan 28, 2025
8 of 11 checks passed
@seabbs seabbs deleted the issue507 branch January 28, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user weighting for marginal models
1 participant