934: fix detection of gaps for forecasts

[sbfnk]

Description

This PR closes #934.

Initial submission checklist

• My PR is based on a package issue and I have explicitly linked it.
• I have tested my changes locally (using devtools::test() and devtools::check()).
• I have added or updated unit tests where necessary.
• I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
• I have followed the established coding standards (and checked using lintr::lint_package()).
• I have added a news item linked to this PR. not done as fixing an issue that has arisen since the last release

After the initial Pull Request

• I have reviewed Checks for this PR and addressed any issues as far as I am able.

[jamesmbaazam]

LGTM. Tried it locally as well to check if it works.

Aside: Should we adapt the plot labels to the accumulation units if uniform? For example, the y-axis still says "per day".

[seabbs]

Should we adapt the plot labels to the accumulation units if uniform? For example, the y-axis still says "per day".

Good idea. Perhaps a new issue for this though?