Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

898: detect initial accumulation #933

Merged
merged 15 commits into from
Jan 31, 2025
Merged

898: detect initial accumulation #933

merged 15 commits into from
Jan 31, 2025

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jan 28, 2025 •
edited
Loading

Description

This PR closes #898.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@sbfnk sbfnk requested review from jamesmbaazam and seabbs January 29, 2025 08:47
@sbfnk sbfnk enabled auto-merge January 29, 2025 08:47
seabbs
seabbs reviewed Jan 30, 2025
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
seabbs
seabbs previously approved these changes Jan 30, 2025
View reviewed changes
jamesmbaazam
jamesmbaazam previously approved these changes Jan 30, 2025
View reviewed changes
R/preprocessing.R Outdated Show resolved Hide resolved
R/preprocessing.R Outdated Show resolved Hide resolved
R/preprocessing.R Outdated Show resolved Hide resolved
R/preprocessing.R Outdated Show resolved Hide resolved
R/preprocessing.R Outdated Show resolved Hide resolved
R/preprocessing.R Outdated Show resolved Hide resolved
@sbfnk sbfnk dismissed stale reviews from jamesmbaazam and seabbs via bc4c74e January 30, 2025 15:33
sbfnk and others added 3 commits January 30, 2025 15:34
@sbfnk @jamesmbaazam
improve variable names
1b97cbc 
as suggested by @jamesmbaazam

Co-authored-by: James Azam <[email protected]>
@sbfnk
add i
58285a3
@sbfnk @jamesmbaazam
missed one
f23ae18 
Co-authored-by: James Azam <[email protected]>
@sbfnk sbfnk requested a review from seabbs January 30, 2025 15:46
@sbfnk sbfnk requested a review from jamesmbaazam January 30, 2025 18:30
jamesmbaazam
jamesmbaazam previously approved these changes Jan 30, 2025
View reviewed changes
@sbfnk sbfnk added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
@sbfnk sbfnk added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 844b8f9 Jan 31, 2025
10 checks passed
@sbfnk sbfnk deleted the detect-accumulate branch January 31, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

@jamesmbaazam jamesmbaazam jamesmbaazam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect accumulation frequency
3 participants
@sbfnk @seabbs @jamesmbaazam