Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data_loader.py - timestamp+id #1572

Merged
merged 2 commits into from
May 30, 2024
Merged

Update data_loader.py - timestamp+id #1572

merged 2 commits into from
May 30, 2024

Conversation

yongzheJIN
Copy link
Contributor

@yongzheJIN yongzheJIN commented May 28, 2024 •
edited
Loading

Based on Further Test scenario:

  1. ID could be int data Type(but it is the pri of row data).
  2. value for not support for date time or timestamp.

Description

I personally use a lot of strange database to test the dashboard. i attached the DCL of my database. you can use this to test it or use your database to test it.

sql.txt

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Snapshots:

image

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@yongzheJIN
Update data_loader.py - timestamp+id
245c592 
Based on Further Test scenario:
1. ID could be int data Type(but it is the pri of row data).
2. value for <ValueItem> not support for date time or timestamp.
(honest it still only support for most case.)
@csunny
Copy link
Collaborator

csunny commented May 29, 2024 •
edited
Loading

@yongzheJIN
The datetime is not import, please fix

name 'datetime' is not defined

@yongzheJIN
Copy link
Contributor Author

@csunny Done. nice check.

csunny
csunny approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Aries-ckt
Aries-ckt approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit 14e159f into eosphoros-ai:main May 30, 2024
4 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
@yongzheJIN @Hopshine
Update data_loader.py - timestamp+id (eosphoros-ai#1572)
ab4fe6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csunny csunny csunny approved these changes

@Aries-ckt Aries-ckt Aries-ckt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yongzheJIN @csunny @Aries-ckt