Generate a predictable and customizable GUI in cuiman #75
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
# Conflicts: # gavicore/src/gavicore/models.py
# Conflicts: # gavicore/src/gavicore/models.py
# Conflicts: # CHANGES.md
# Conflicts: # CHANGES.md
pont-us
approved these changes
Apr 7, 2026
Collaborator
pont-us
left a comment
There was a problem hiding this comment.
Quite a few comments and suggestions, but approving since I don't need to review again.
clarasb
requested changes
Apr 7, 2026
Collaborator
clarasb
left a comment
There was a problem hiding this comment.
Really nice!
I have some small suggestions and I made some observations while running pixi run schema2ui. For the observations see the comments in gavicore/tests/ui/schemas/.
Co-authored-by: Pontus Lurcock <pontus.lurcock@brockmann-consult.de>
Co-authored-by: Pontus Lurcock <pont@talvi.net> Co-authored-by: Clara Backens <64074334+clarasb@users.noreply.github.com>
Collaborator
Author
|
@clarasb I'd like to not fix the individual editor issues you discovered in this PR and instead create new ones, because they are cleanly isolated. They are
|
clarasb
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gavicore package has been enhanced by a new UI generator which converts OGC API - Process descriptions (or OpenAPI Schema) into user interfaces for editing input parameters:
gavicore.ui.cuiman.gui.component.pixi run schema2ui.Addresses #74
Closes #55
Closes #37
Closes #38
Note that many points described in #74 are not addressed in this PR but will be addressed in follow-up PRs:
discriminator,oneOf,anyOf,allOf,$ref, and some moreClientConfig.is_advanced_input()to the new solution (see TODO).gavicore.uicode and create an umbrella issueThe best way to start reviewing this PR is running the new schema2ui tool understand the tool's code and debug into the UI generation process:
Checklist (strike out non-applicable):
CHANGES.mdCHANGES.mddocs/*(just architecture diagrams, docs still needed, see Document the client GUI #42)