Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the MP4V2_ prefix to CMake options #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

corporateshark
Copy link

When this library is a part of another CMake-based project, global options BUILD_SHARED and BUILD_UTILS interfere with other projects.

Renamed both CMake options as follows:

MP4V2_BUILD_SHARED
MP4V2_BUILD_UTILS

@ferdnyc
Copy link

ferdnyc commented Feb 27, 2024

This will also causes the cmake-gui interface to group the options together under an MP4V2 heading. Right now they're grouped under "BUILD" which doesn't make sense (particularly when used as a subproject).

Before:

image

After:

image

@ferdnyc
Copy link

ferdnyc commented Feb 27, 2024

(Although, honestly, BUILD_SHARED should probably be replaced with support for the built-in CMake variable BUILD_SHARED_LIBS.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants