HTTP2: change the default reset code from no error to internal error #42269
+209
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wbpcode <[email protected]>
wbpcode
commented
Nov 26, 2025
Comment on lines
-897
to
+924
| codec_callbacks_->onCodecLowLevelReset(); | ||
| // TODO(wbpcode): this ensure that onCodecLowLevelReset is only called once. But | ||
| // we should replace this with a better design later. | ||
| // See https://github.com/envoyproxy/envoy/issues/42264 for why we need this. | ||
| if (!codec_low_level_reset_is_called_) { | ||
| codec_low_level_reset_is_called_ = true; | ||
| codec_callbacks_->onCodecLowLevelReset(); | ||
| } |
Member
Author
There was a problem hiding this comment.
This PR changed the default stream reset code and will enlarger the problem in the #42264. So, I made a quick work around to resolve problem here.
Member
Author
|
Compare to the change in the #40729, this PR removed all RemoteResetNoError related things. This is because:
|
Signed-off-by: wbpcode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: HTTP2: change the default reset code from no error to internal error
Additional Description:
This PR makes Envoy generate less NO_ERROR from the codec when there is a stream reset to close #36200.
https://httpwg.org/specs/rfc9113.html#RST_STREAM
https://httpwg.org/specs/rfc9113.html#ErrorCodes
Thanks so much for the great work from @botengyao in the #40729
Risk Level: mid.
Testing: unit + integration
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]