ext_authz: fixes a bug in the retry_policy to respective user's config #42232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Agrawal <[email protected]>
wbpcode
reviewed
Nov 25, 2025
Comment on lines
116
to
117
| Http::Utility::convertCoreToRouteRetryPolicy(core_retry_policy, | ||
| "5xx,gateway-error,connect-failure,reset"); | ||
| Http::Utility::convertCoreToRouteRetryPolicy(core_retry_policy, ""); |
Member
There was a problem hiding this comment.
What will happen is the retry_on of user's configuration is empty? Or is that possible?
Member
Author
There was a problem hiding this comment.
If the user's retry_on configuration is empty, then retries will be effectively disabled which seems to be the correct behavior. What do you think?
Member
Author
There was a problem hiding this comment.
i added it behind a new runtime guard as we discussed offline :)
Signed-off-by: Rohit Agrawal <[email protected]>
Signed-off-by: Rohit Agrawal <[email protected]>
wbpcode
approved these changes
Nov 27, 2025
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the ExtAuthZ HTTP behavior where we keep using the hardcoded defaults and ignore the policy passed in by the user.
Commit Message: ext_authz: fixes a bug in the retry_policy to respective user's config
Additional Description: Fixes the ExtAuthZ HTTP behavior where we keep using the hardcoded defaults and ignore the policy passed in by the user.
Risk Level: Low
Testing: Added Integration Tests
Docs Changes: Added
Release Notes: Added