Skip to content

Conversation

shane-yuan
Copy link

@shane-yuan shane-yuan commented Sep 9, 2025

Commit Message: register sign to wasm
Additional Description:
Risk Level: low. New function added.
Testing: unit
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
[Optional Runtime guard:]
[Optional Fixes #31615
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Commit Message: register sign to wasm
Additional Description:
Risk Level: low. New function added.
Testing: unit
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
[Optional Runtime guard:]
[Optional Fixes envoyproxy#3768
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Shane Yuan <[email protected]>
Copy link

Hi @shane-yuan, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #41032 was opened by shane-yuan.

see: more, trace.

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #41032 was opened by shane-yuan.

see: more, trace.

Copy link

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/coverage.yaml).
envoyproxy/coverage-shephards assignee is @RyanTheOptimist

🐱

Caused by: #41032 was opened by shane-yuan.

see: more, trace.

@shane-yuan
Copy link
Author

@RyanTheOptimist I created this new PR after closing my previous PR, whose branch history was messed up when I tried to fix the missing sign-off issue. Sorry about the confusion.

@shane-yuan shane-yuan marked this pull request as ready for review September 9, 2025 21:49
@shane-yuan
Copy link
Author

/retest

@shane-yuan
Copy link
Author

@wbpcode @kyessenov @RyanTheOptimist Could you please review my PR?

@RyanTheOptimist
Copy link
Contributor

@RyanTheOptimist I created this new PR after closing my previous PR, whose branch history was messed up when I tried to fix the missing sign-off issue. Sorry about the confusion.

In the future, please don't create new PRs in cases like that. We can help with the git issues, I think :) But no worries this time.

@RyanTheOptimist
Copy link
Contributor

/assign @kyessenov for wasm

Copy link

neither of for, wasm can be assigned to this issue.

🐱

Caused by: a #41032 (comment) was created by @RyanTheOptimist.

see: more, trace.

@RyanTheOptimist
Copy link
Contributor

/assign @ggreenway for the crypto changes

Copy link

neither of for, the, crypto, changes can be assigned to this issue.

🐱

Caused by: a #41032 (comment) was created by @RyanTheOptimist.

see: more, trace.

@RyanTheOptimist
Copy link
Contributor

Is there a github issue associated with this PR? I see that the PR description mentions #3768, but that seems to already be closed.

@shane-yuan
Copy link
Author

Is there a github issue associated with this PR? I see that the PR description mentions #3768, but that seems to already be closed.

It should be 31615. Let me fix my comment. Support FIPs crypto from WASM plugin was closed with wasm: register verify_signature as foreign function #32127. It is to add the missing sign feature so that WASM can both sign and verify signatures using FIPS crypto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support FIPs crypto from WASM plugin
2 participants