-
Notifications
You must be signed in to change notification settings - Fork 5.1k
wasm: register sign as foreign function #41032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Commit Message: register sign to wasm Additional Description: Risk Level: low. New function added. Testing: unit Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a [Optional Runtime guard:] [Optional Fixes envoyproxy#3768 [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:] Signed-off-by: Shane Yuan <[email protected]>
Hi @shane-yuan, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
@RyanTheOptimist I created this new PR after closing my previous PR, whose branch history was messed up when I tried to fix the missing sign-off issue. Sorry about the confusion. |
/retest |
@wbpcode @kyessenov @RyanTheOptimist Could you please review my PR? |
In the future, please don't create new PRs in cases like that. We can help with the git issues, I think :) But no worries this time. |
/assign @kyessenov for wasm |
neither of for, wasm can be assigned to this issue. |
/assign @ggreenway for the crypto changes |
neither of for, the, crypto, changes can be assigned to this issue. |
Is there a github issue associated with this PR? I see that the PR description mentions #3768, but that seems to already be closed. |
It should be 31615. Let me fix my comment. Support FIPs crypto from WASM plugin was closed with wasm: register verify_signature as foreign function #32127. It is to add the missing sign feature so that WASM can both sign and verify signatures using FIPS crypto. |
Commit Message: register sign to wasm
Additional Description:
Risk Level: low. New function added.
Testing: unit
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
[Optional Runtime guard:]
[Optional Fixes #31615
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]