Skip to content

Conversation

@dependency-envoy
Copy link
Contributor

Created by Envoy dependency bot for @phlax

Fix #38105

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jan 23, 2025
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #38162 was opened by dependency-envoy[bot].

see: more, trace.

phlax added 2 commits January 23, 2025 12:59
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@phlax
Copy link
Member

phlax commented Jan 23, 2025

needs an android fix cc @abeyad

@phlax phlax changed the title deps: Bump rules_java -> 8.7.1 [WIP] deps: Bump rules_java -> 8.7.1 Jan 23, 2025
@phlax phlax marked this pull request as draft January 23, 2025 18:01
@phlax
Copy link
Member

phlax commented Jan 23, 2025

rules_java 8.x is intended for use with Bazel 8 onwards.

bazelbuild/rules_java#233 (comment)

@abeyad
Copy link
Contributor

abeyad commented Jan 23, 2025

@fredyw looked into the rules java updates; I think there were some blockers that needed to be resolved. Fredy could you shed some light?

@fredyw
Copy link
Member

fredyw commented Jan 23, 2025

@fredyw looked into the rules java updates; I think there were some blockers that needed to be resolved. Fredy could you shed some light?

I replied in #37661 (comment) given that I ran into a number of issues with updating Android related rules.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Feb 22, 2025
@github-actions
Copy link

github-actions bot commented Mar 2, 2025

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Mar 2, 2025
@phlax phlax deleted the dependency/bazel/rules_java/8.7.1 branch July 24, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies stale stalebot believes this issue/PR has not been touched recently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newer release available rules_java: 8.7.1 (current: 7.12.3)

5 participants