Repository navigation
Conversation
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add zlib_lib label_flag injection to grpc module patch
Add Sep 24, 2026
zlib_lib injection point to grpc 1.83.0.envoy patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpc's Envoy patch exposed
ssl_libandcrypto_liboverride points, butthird_party:madler_zlibremained hard-wired to@zlib//:zlib. This prevented downstream consumers from redirecting grpc to their own zlib target and could pull both@zliband@zlib-nginto the same build graph.grpc patch
third_party/BUILDpatch inmodules/grpc/1.83.0.envoy/patches/grpc.patchlabel_flag:madler_zlibthrough that flag instead of the upstream hard-coded alias:registry metadata
modules/grpc/1.83.0.envoy/source.jsonwith the newgrpc.patchintegrity hash for the in-place patch editresult
@zlibtarget