Conversation
Add support for Arbitrum Nitro-specific transaction fields used in L1-to-L2 messaging and retryable tickets: request_id, ticket_id, refund_to, max_refund, submission_fee_refund, l1_base_fee, deposit_value, retry_to, retry_value, retry_data, beneficiary, and max_submission_fee. All fields are Option<T> for backwards compatibility. Updated across the full stack: hypersync-format types, hypersync-schema Arrow definitions, Cap'n Proto schema and generated bindings, net-types TransactionField enum (with is_nullable/to_capnp/from_capnp), Arrow reader methods, from_arrow conversion, and simple_types client-facing struct. Co-authored-by: claude <noreply@anthropic.com> https://claude.ai/code/session_014p42VVh5CT3RUC4dzGKV3y
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (4)
📝 WalkthroughWalkthroughAdds twelve optional Arbitrum Nitro transaction fields (request_id, ticket_id, refund_to, max_refund, submission_fee_refund, l1_base_fee, deposit_value, retry_to, retry_value, retry_data, beneficiary, max_submission_fee) across schema, capnp/net-types, format/client Transaction structs, Arrow reader getters, and Arrow-to-Transaction deserialization; also consolidates CI packaging and bumps crate versions. ChangesArbitrum Nitro Transaction Fields
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
- hypersync-format: 0.7.0 → 0.8.0-arbitrum-test.0 - hypersync-schema: 0.4.0 → 0.5.0-arbitrum-test.0 - hypersync-net-types: 0.12.3 → 0.13.0-arbitrum-test.0 - hypersync-client: 1.1.4 → 1.2.0-arbitrum-test.0 Co-authored-by: claude <noreply@anthropic.com> https://claude.ai/code/session_014p42VVh5CT3RUC4dzGKV3y
Package all crates in a single cargo package command so Cargo resolves inter-workspace dependencies locally instead of looking them up on crates.io (where prerelease versions don't exist yet). Co-authored-by: claude <noreply@anthropic.com>
| [package] | ||
| name = "hypersync-format" | ||
| version = "0.7.0" | ||
| version = "0.8.0-arbitrum-test.0" |
There was a problem hiding this comment.
Lets bump this to an actual release version before merging to main.
JonoPrest
left a comment
There was a problem hiding this comment.
Rebase on main and bump versions without special flags then go ahead and merge + release
|
Thanks Jono. I'm actually going to close this. I've decided we will skip these additional fields. I should've probably closed this earlier. |
Add support for Arbitrum Nitro-specific transaction fields used in L1-to-L2 messaging and retryable tickets: request_id, ticket_id, refund_to, max_refund, submission_fee_refund, l1_base_fee, deposit_value, retry_to, retry_value, retry_data, beneficiary, and max_submission_fee.
All fields are Option for backwards compatibility. Updated across the full stack: hypersync-format types, hypersync-schema Arrow definitions, Cap'n Proto schema and generated bindings, net-types TransactionField enum (with is_nullable/to_capnp/from_capnp), Arrow reader methods, from_arrow conversion, and simple_types client-facing struct.
Co-authored-by: claude noreply@anthropic.com
https://claude.ai/code/session_014p42VVh5CT3RUC4dzGKV3y
Summary by CodeRabbit