Code Cleaning #49
Draft
Code Cleaning #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Jack. Yes, I wish to pursue this further. I have already booked a follow-up code clinic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jakharkaran - as discussed at the Climate Code Clinic, there is quite a lot we can do to improve this repo from the software side.
I started to have a look at some packaging after #45, but ran in to a few issues with the way the code is structured at present.
As a result I stepped back and have started to look at some basic code cleaning and hygiene.
This PR is still WIP, but I have uploaded an example of starting to apply this to
Py2D_Solver.py.If this is something you'd be interested in pursuing further let me know.
It would need a fair bit of communication to make sure we both agree and understand any changes.
The best way to proceed may be to book a follow-up Climate Code Clinic to discuss further.