Skip to content

Enable git-repo-path to choose its source directory.#9

Open
titanlien wants to merge 2 commits into
entrostat:mainfrom
titanlien:feature/add-git-repo-path
Open

Enable git-repo-path to choose its source directory.#9
titanlien wants to merge 2 commits into
entrostat:mainfrom
titanlien:feature/add-git-repo-path

Conversation

@titanlien
Copy link
Copy Markdown

  • git-repo-path is storing directory .gitsecret

@titanlien titanlien force-pushed the feature/add-git-repo-path branch from 384ff33 to cf9152b Compare September 23, 2024 15:28
@titanlien titanlien force-pushed the feature/add-git-repo-path branch 2 times, most recently from e9440e9 to 8c4c396 Compare September 24, 2024 14:30
@kerren
Copy link
Copy Markdown
Contributor

kerren commented Sep 24, 2024

@titanlien what would a use case for this be? Is it when you have a submodule?

Copy link
Copy Markdown
Contributor

@kerren kerren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably make a change here in terms of the description?

Comment thread action.yml Outdated
Co-authored-by: Kerren Ortlepp <kerren@entrostat.com>
@titanlien
Copy link
Copy Markdown
Author

titanlien commented Sep 25, 2024

@titanlien what would a use case for this be? Is it when you have a submodule?

When we use actions/checkout@v4 image like the following setting. Then this image can't find its checkout secrets-directory directory.

      - name: Git clone the secrets repository
        uses: actions/checkout@v4
        with:
          repository: secrets-repo
          ref: ...
          token: ...
          path: secrets-directory

@titanlien titanlien requested a review from kerren September 25, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants