fix: isolate mirror PR cache entries - #928
Closed
Helios531 wants to merge 1 commit into
Closed
Conversation
Helios531
force-pushed
the
fix/mirror-cache-fill-gap-824
branch
from
May 1, 2026 20:29
7d537ae to
b8c0445
Compare
Helios531
force-pushed
the
fix/mirror-cache-fill-gap-824
branch
from
May 2, 2026 14:08
aee33e8 to
6ee9513
Compare
Collaborator
|
Verified the claimed leakage doesn't manifest — every field listed in the issue is fresh-assigned in Phase 1 of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a cache isolation gap where mirror PR objects returned from
MinerEvaluationCache.get()could shareScoredMirrorPRinstances with the cached snapshot.When cache fallback is used,
finalize_miner_scores()mutates top-level PR scoring fields such asearned_score,collateral_score,open_pr_spam_multiplier,credibility_multiplier,pioneer_rank, andpioneer_dividend. Legacy PRs were already protected by fresh top-levelPullRequestcopies, but mirror PR buckets were not.Changes
mirror_merged_prsmirror_open_prsmirror_closed_prsScoredMirrorPR.filesValidation
Fixes #927