Skip to content

refactor(storage): dedupe repeated u128 little-endian decode into a helper #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
minion1227 wants to merge 2 commits into from
Closed

refactor(storage): dedupe repeated u128 little-endian decode into a helper #1585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5a7fa7
refactor(storage): extract _decode_u128le for repeated u128 decode
minion1227 Jul 5, 2026
1c3d395
style: ruff-format submissions.py to satisfy --all-files fork CI
minion1227 Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions gittensor/cli/issue_commands/submissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ def issues_submissions(
if pull_requests is None:
handle_exception(
as_json,
f'GitHub lookup failed for {repo_name}#{issue_number}; '
'submissions could not be determined. Please retry.',
f'GitHub lookup failed for {repo_name}#{issue_number}; submissions could not be determined. Please retry.',
'github_lookup_failed',
)

Expand Down
15 changes: 9 additions & 6 deletions gittensor/validator/issue_competitions/storage_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@
ISSUES_MAPPING_ROOT_KEY = '52789899'


def _decode_u128le(data: bytes, offset: int) -> int:
"""Decode a little-endian u128 (two u64 limbs) from ``data`` at ``offset``."""
lo, hi = struct.unpack_from('<QQ', data, offset)
return lo + (hi << 64)


@dataclass
class PackedContractStorage:
"""Decoded root packed storage layout for the issue competition contract."""
Expand Down Expand Up @@ -107,8 +113,7 @@ def decode_packed_contract_storage(data: bytes) -> Optional[PackedContractStorag
offset += 2
next_issue_id = struct.unpack_from('<Q', data, offset)[0]
offset += 8
alpha_pool_lo, alpha_pool_hi = struct.unpack_from('<QQ', data, offset)
alpha_pool = alpha_pool_lo + (alpha_pool_hi << 64)
alpha_pool = _decode_u128le(data, offset)
except (struct.error, IndexError) as e:
logger.debug('Failed to decode packed contract storage: %s', e)
return None
Expand Down Expand Up @@ -162,12 +167,10 @@ def decode_issue_from_storage(data: bytes) -> Optional[DecodedIssueStorage]:
issue_number = struct.unpack_from('<I', data, offset)[0]
offset += 4

bounty_lo, bounty_hi = struct.unpack_from('<QQ', data, offset)
bounty_amount = bounty_lo + (bounty_hi << 64)
bounty_amount = _decode_u128le(data, offset)
offset += 16

target_lo, target_hi = struct.unpack_from('<QQ', data, offset)
target_bounty = target_lo + (target_hi << 64)
target_bounty = _decode_u128le(data, offset)
offset += 16

status_byte = data[offset]
Expand Down
Loading