fix(leaderboard): explain global-rank gaps when filters are active#1328
Merged
anderdc merged 1 commit intoJun 11, 2026
Merged
Conversation
anderdc
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The leaderboard
#column shows each miner's global rank (position across all ~110 miners). When a filter is active — most visiblyEligibility = Eligible— the non-matching rows are hidden but the survivors keep their global rank numbers, so the column appears to "skip" (e.g.… 21, 22, 33, 107). The math is correct, but the gaps read as a bug.This PR keeps the meaningful global rank and makes the gaps self-explanatory:
#column header explaining the same.Presentation-only — no sort/filter/ranking logic changed. The note lives in the shared toolbar, so it covers both list and card views. Implemented in
MinersLeaderTable.tsx(the component rendered at/leaderboard); the issue's original reference toTopMinersTable.tsx//top-minersis stale since that route now redirects to/leaderboard.Related Issues
Fixes #1102
Type of Change
Screenshots
The gap (problem):

Before — no explanation, gaps look like a bug:
After — note added above the table explaining the global-rank gaps:
After (no filter) — note correctly hidden, ranks consecutive:
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses