Skip to content

fix(leaderboard): explain global-rank gaps when filters are active#1328

Merged
anderdc merged 1 commit into
entrius:testfrom
Crystora:fix/issue-1102-leaderboard-rank-filter-context
Jun 11, 2026
Merged

fix(leaderboard): explain global-rank gaps when filters are active#1328
anderdc merged 1 commit into
entrius:testfrom
Crystora:fix/issue-1102-leaderboard-rank-filter-context

Conversation

@Crystora

@Crystora Crystora commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

The leaderboard # column shows each miner's global rank (position across all ~110 miners). When a filter is active — most visibly Eligibility = Eligible — the non-matching rows are hidden but the survivors keep their global rank numbers, so the column appears to "skip" (e.g. … 21, 22, 33, 107). The math is correct, but the gaps read as a bug.

This PR keeps the meaningful global rank and makes the gaps self-explanatory:

  • Adds a one-line note above the table, shown only when a filter is active (eligibility tab, cohort, tracked-only, repo, or search): "Filtered view — the # column shows global rank across all miners, so hidden miners leave gaps in the numbering."
  • Adds a tooltip on the # column header explaining the same.

Presentation-only — no sort/filter/ranking logic changed. The note lives in the shared toolbar, so it covers both list and card views. Implemented in MinersLeaderTable.tsx (the component rendered at /leaderboard); the issue's original reference to TopMinersTable.tsx / /top-miners is stale since that route now redirects to /leaderboard.

Related Issues

Fixes #1102

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Screenshots

The gap (problem):
ISSUE_1102_rank_gaps

Before — no explanation, gaps look like a bug:

BEFORE_filtered_card

After — note added above the table explaining the global-rank gaps:

AFTER_filtered_card

After (no filter) — note correctly hidden, ranks consecutive:

AFTER_unfiltered_card

Checklist

  • New components are modularized/separated where sensible
  • Uses predefined theme (e.g. no hardcoded colors)
  • Responsive/mobile checked
  • Tested against the test API
  • npm run format and npm run lint:fix have been run
  • npm run build passes
  • Screenshots included for any UI/visual changes

@xiao-xiao-mao xiao-xiao-mao Bot added the enhancement New feature or request label Jun 9, 2026
@anderdc anderdc merged commit dcd0861 into entrius:test Jun 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UX] Leaderboard rank column shows global ranks with unexplained gaps under any filter

2 participants