Skip to content

fix(miners): window CLOSED PRs by closed_at instead of created_at#184

Closed
kiannidev wants to merge 1 commit into
entrius:testfrom
kiannidev:fix/182-miners-closed-pr-closed-at
Closed

fix(miners): window CLOSED PRs by closed_at instead of created_at#184
kiannidev wants to merge 1 commit into
entrius:testfrom
kiannidev:fix/182-miners-closed-pr-closed-at

Conversation

@kiannidev

@kiannidev kiannidev commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Use closed_at >= since for CLOSED pull requests in both getPullRequests and getPullRequestsByRepo
  • Aligns miner /pulls windowing with /issues and MERGED PR handling

Related Issues

Fixes #182

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Testing

  • npm run build in packages/das passes

Checklist

  • I have read the Contributing Guide
  • Code builds without errors
  • New and existing tests pass (if applicable)
  • Documentation updated (if applicable)
  • No unnecessary dependencies added

@anderdc

anderdc commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

CLOSED PRs are windowed by created_at by design — the /issues parallel doesn't hold because issues have no merged state and don't feed the credibility ratio, so there's no inconsistency to fix here. Closing.

@anderdc anderdc closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] miners API: CLOSED pull requests filtered by created_at instead of closed_at

2 participants