Reschedule guest code execution into dedicated thread pool #12613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tations can happen later
JaroslavTulach
added
the
CI: No changelog needed
6 tasks
JaroslavTulach
force-pushed
the
wip/jtulach/GuestCodeExecutor12500
branch
from
e3b2be8 to
b591593
Compare
|
There are three remaining failures in
The rest of the JVM tests seems to be green. |
2 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
- based on experiments made in #12613 that are by themselves motivated by #12500 - `TruffleLogger` shall **only be used** in the interpreter running _guest code_ - most of the code in `runtime-instrument-xyz` projects is **not** running a _guest code_ - most of the code in these instruments schedules runs of _guest code_ - thus using `TruffleLogger` isn't appropriate and it yields exception when it cannot find `EnsoContext` around - let's make the code ready for _context_ **not being around** - let's use SLF4J instead of `TruffleLogger`
2 tasks
2 tasks
It flies!
|
JaroslavTulach
commented
Mar 27, 2025
| @@ -794,33 +792,36 @@ public boolean isGlobalSuggestionsEnabled() { | |||
|
|
|||
| /** The job parallelism or 1 */ | |||
| public int getJobParallelism() { | |||
| var n = getOption(RuntimeOptions.JOB_PARALLELISM_KEY); | |||
| var base = n == null ? 1 : n.intValue(); | |||
| var optimal = Math.round(base * 0.5); | |||
There was a problem hiding this comment.
- I don't really understand this
base * 0.5logic!? - seems to be result of Improvements that significantly reduce the chances of request timeouts #7042
- it is a PR with long description
- but it doesn't explain why the
baseis being divided into half?
|
JaroslavTulach
commented
Mar 28, 2025
| override def contextModifiers: Option[Context#Builder => Context#Builder] = | ||
| Some(b => { | ||
| b.allowCreateThread(true) | ||
| .option(RuntimeOptions.JOB_PARALLELISM, "" + parallelism) |
There was a problem hiding this comment.
- this test no longer allocates its own
new Thread, but it relies on builtinJOB_PARALLELISM - this could help a lot with - Improve visualizations feedback via cache observables and safepoints #10525
- enough to increase value of
JOB_PARALLELISM(default remains1) - schedule visualization computations as
getThreadManager.submit - and they will be executed in parallel to regular computation
JaroslavTulach
commented
Mar 28, 2025
| } | ||
| return null; | ||
| }); | ||
| resultOf(pending); |
There was a problem hiding this comment.
ExecutionServicekeeps compatibility with previous blocking behavior- even the Enso code computation is performed in guest thread
- it has to to address Upgrading to Truffle libraries 24.2.0 #12500 (comment)
- e.g. the code is
submited toThreadManagerfor execution Futureis returned- but all methods in
ExecutionServicewait for suchFutures to be finished - these methods could be changed to return
Futurein subsequent PRs - that would help with Improve visualizations feedback via cache observables and safepoints #10525
- e.g. this PR opens the door for parallel evaluation of visualizations
4e6
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Enso is using Truffle threads and especially those that allow execution of guest code too much. A lot of other code is running in such threads. However those threads are subject to special control and support from Truffle framework (for example execution of safepoints).
Let's reduce the usage of those Truffle threads to a minimum. Leave the other threads "normal".
Important Notes
ThreadManager.interruptThreads()is essential for this PRRuntimeAsyncCommandsTestwill not passChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,