External Service Credentials #12454
Draft
External Service Credentials #12454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
added
CI: No changelog needed
🧪 Storybook is successfully deployed!📊 Dashboard:
|
radeusgd
reviewed
Mar 12, 2025
| @@ -219,6 +221,10 @@ export function deleteUserGroupPath(groupId: backend.UserGroupId) { | |||
| export function getCheckoutSessionPath(checkoutSessionId: backend.CheckoutSessionId) { | |||
| return `${GET_CHECKOUT_SESSION_PATH}/${checkoutSessionId}` | |||
| } | |||
| /** Relative HTTP path to the "get oauth callback" endpoint of the Cloud backend API. */ | |||
| export function getOauthCallbackPath(service: backend.CredentialInput['type']) { | |||
| return `libs/${service}/oauth/callback` | |||
There was a problem hiding this comment.
I thought we were aiming for oauth/${service}/callback?
I really don't see why there's libs in there - @radeusgd from "Libs Team" was working on the endpoint, yes, but other than that it is not closer tied to libs than e.g. secrets or datalinks are, and these don't have such a prefix.
…ype assertion as they already get `form` from the `FormContext`
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.