Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute chromatic tests only when label is present #12216

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Feb 3, 2025

Pull Request Description

Closes: https://github.com/enso-org/cloud-v2/issues/1795

This PR:

  1. Changes behavior of storybook deployment - now it triggers on if the label is set
  2. Adds rich summary for GUI checks, deploys PW report to gh pages.
  3. Updates labels for other jobs (to better distinguish them)
  4. Displays ESlint errors straight in the PR.
  5. Fixes eslint reporter: improve perf, exclude duplicates.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@MrFlashAccount MrFlashAccount added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 3, 2025
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/run-chromatic-on-label branch from 59b9bfb to d3991bf Compare February 3, 2025 14:22
@MrFlashAccount MrFlashAccount added CI: Run Chromatic Enables Chromatic tests run and removed CI: Run Chromatic Enables Chromatic tests run labels Feb 3, 2025
@MrFlashAccount MrFlashAccount changed the title wip/sergeigarin/run-chromatic-on-label Execute chromatic tests only when label is present Feb 3, 2025
@MrFlashAccount MrFlashAccount added CI: Run Chromatic Enables Chromatic tests run and removed CI: Run Chromatic Enables Chromatic tests run labels Feb 3, 2025
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/run-chromatic-on-label branch from 775547a to 6158a3c Compare March 8, 2025 11:05
@MrFlashAccount MrFlashAccount removed the CI: Run Chromatic Enables Chromatic tests run label Mar 8, 2025
@MrFlashAccount MrFlashAccount self-assigned this Mar 8, 2025
@MrFlashAccount MrFlashAccount added the CI: Run Chromatic Enables Chromatic tests run label Mar 8, 2025
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/run-chromatic-on-label branch from 35feecf to 14ddfa3 Compare March 8, 2025 13:07
@MrFlashAccount MrFlashAccount removed the CI: Run Chromatic Enables Chromatic tests run label Mar 8, 2025
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/run-chromatic-on-label branch from d4397ff to 2e6fb54 Compare March 8, 2025 14:46
@enso-org enso-org deleted a comment from github-actions bot Mar 8, 2025
@enso-org enso-org deleted a comment from github-actions bot Mar 8, 2025
@enso-org enso-org deleted a comment from github-actions bot Mar 8, 2025
@enso-org enso-org deleted a comment from github-actions bot Mar 8, 2025
@enso-org enso-org deleted a comment from github-actions bot Mar 8, 2025
@enso-org enso-org deleted a comment from github-actions bot Mar 9, 2025
@enso-org enso-org deleted a comment from github-actions bot Mar 9, 2025
@MrFlashAccount MrFlashAccount added the CI: Run Chromatic Enables Chromatic tests run label Mar 9, 2025
@enso-org enso-org deleted a comment from github-actions bot Mar 9, 2025
@MrFlashAccount MrFlashAccount added CI: Run Chromatic Enables Chromatic tests run and removed CI: Run Chromatic Enables Chromatic tests run labels Mar 9, 2025
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/run-chromatic-on-label branch from 71d7544 to 456bdc2 Compare March 9, 2025 11:21
@MrFlashAccount MrFlashAccount removed the CI: Run Chromatic Enables Chromatic tests run label Mar 9, 2025
@MrFlashAccount MrFlashAccount added CI: Run Chromatic Enables Chromatic tests run and removed CI: Run Chromatic Enables Chromatic tests run labels Mar 9, 2025
Copy link

github-actions bot commented Mar 9, 2025

✨ GUI Checks Results

Summary

  • 🧹 Prettier: ✅ Passed
  • 🧰 GUI Checks: ❌ Failed
  • 📚 Storybook: ✅ Deployed

⚠️ Action Required: Please review the failed checks and fix them before merging.

See individual check results for more details.

ℹ️ Chromatic Tests Skipped

Chromatic visual regression tests were skipped for this PR.

To run the tests and deploy Storybook, add the CI: Run Chromatic label to this PR.

Note: We skip tests by default to optimize CI costs. Only run them when your UI changes are ready for review.

👮 Lint GUI Results

Check Results

  • 🧠 Typecheck: ✅ Passed
  • 🧹 Lint: ✅ Passed
  • 🧪 Unit Tests: ✅ Passed

🎭 Playwright Test Results

Summary

  • ⏳ Duration: 6m 0s
  • ✅ Passed: 309 tests
  • 🔴 Failed: 2 tests
  • ⚠️ Flaky: 0 tests

View Detailed Report ↗️

⚠️ Action Required: Please review the failed tests and fix them before merging.

@MrFlashAccount MrFlashAccount added CI: Run Chromatic Enables Chromatic tests run and removed CI: Run Chromatic Enables Chromatic tests run labels Mar 9, 2025
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/run-chromatic-on-label branch from 9723a8d to 60c1e98 Compare March 9, 2025 14:02
@MrFlashAccount MrFlashAccount marked this pull request as ready for review March 9, 2025 14:07
@@ -42,7 +42,7 @@ jobs:
secrets: inherit

required-checks:
name: Engine Required Checks
name: 🚂 Engine Required Checks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't rename the jobs - we are busy working towards a release and we can align after the release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine to merge this PR after the release 👌 This can wait

@MrFlashAccount MrFlashAccount added CI: Keep up to date Automatically update this PR to the latest develop. and removed CI: Run Chromatic Enables Chromatic tests run labels Mar 20, 2025
@MrFlashAccount MrFlashAccount removed the CI: Keep up to date Automatically update this PR to the latest develop. label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants