Skip to content

chore: remove redundant and trivial comments#54

Merged
enginerd-kr merged 2 commits into
mainfrom
chore/cleanup-outdated-comments
Apr 3, 2026
Merged

chore: remove redundant and trivial comments#54
enginerd-kr merged 2 commits into
mainfrom
chore/cleanup-outdated-comments

Conversation

@enginerd-kr

Copy link
Copy Markdown
Owner

Summary

  • Remove ~300 lines of unnecessary comments across 19 source files
  • Cleaned up trivial inline comments that repeat what the code says (e.g., # Verify ownership, # Build updates dictionary)
  • Removed decorative section dividers (# ========, # ----------)
  • Removed dead code block in Redis storage (if pipeline is None: pass)
  • Preserved meaningful design comments (e.g., misfire policy explanations, hash ordering rationale)

Test plan

  • make lint passes
  • make type-check passes
  • All 418 unit/integration tests pass

🤖 Generated with Claude Code

Remove ~300 lines of unnecessary comments that repeat what the code
already says, including section dividers, trivial inline annotations,
and dead code blocks. Meaningful design comments are preserved.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@enginerd-kr

Copy link
Copy Markdown
Owner Author

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  chronis
  __init__.py
  type_defs.py
  chronis/adapters/lock
  memory.py 157, 227
  chronis/adapters/storage
  memory.py
  chronis/contrib/adapters/lock
  redis.py 112-131, 138-143, 164-175, 198-209
  chronis/contrib/adapters/storage
  redis.py 122-129, 139-148, 167-176, 242-261, 287-332, 344-352, 380-410, 419-426
  chronis/contrib/adapters/storage/postgres
  adapter.py 194-202, 248-253, 260-273, 299-304, 335-362, 372-381
  migration.py
  chronis/core
  __init__.py
  chronis/core/base
  scheduler.py
  chronis/core/common
  exceptions.py
  chronis/core/execution
  coordinator.py 82
  job_executor.py
  job_queue.py
  chronis/core/jobs
  definition.py
  chronis/core/schedulers
  fluent_builders.py
  polling_scheduler.py 425
  chronis/core/triggers
  cron_calc.py 424
  chronis/utils
  logging.py 23
Project Total  

This report was generated by python-coverage-comment-action

The multiline YAML block scalar was causing the JSON schema to be
truncated to just "{" when parsed by claude-code-action, making
the Claude review step hang indefinitely.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@enginerd-kr
enginerd-kr merged commit 5d989aa into main Apr 3, 2026
2 of 3 checks passed
@enginerd-kr
enginerd-kr deleted the chore/cleanup-outdated-comments branch April 3, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant