Fix RRD4j config naming for Felix ConfigAdmin#63
Open
amalbet wants to merge 2 commits intofeature/setup-scriptfrom
Open
Fix RRD4j config naming for Felix ConfigAdmin#63amalbet wants to merge 2 commits intofeature/setup-scriptfrom
amalbet wants to merge 2 commits intofeature/setup-scriptfrom
Conversation
The previous config file (Timedata/Rrd4j.config) was not being picked up by Felix ConfigAdmin because factory configs require the FactoryPID/<uuid>.config directory pattern. Rename to Timedata/Rrd4j/<uuid>.config to match other factory configs (Controller/Api/Backend/<uuid>.config, etc.). Also adds Edge config volume mount and setup.sh validation. Closes #61 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Felix ConfigAdmin's FilePersistenceManager derives the PID from the file path (dots → directory separators). The file Timedata/Rrd4j/<name>.config maps to PID Timedata.Rrd4j.<name>, so the filename must be rrd4j0.config to match service.pid=Timedata.Rrd4j.rrd4j0. Verified locally: component state changes from "no config" to "active". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Timedata/Rrd4j.config) to factory pattern (Timedata/Rrd4j/<uuid>.config)./openems-edge/config.d:/etc/openems.d) to docker-compose.ymlsetup.shSupersedes the config from PR #62 which used the wrong naming convention.
Context
Testing revealed that Felix ConfigAdmin requires factory configs to use the
FactoryPID/<uuid>.configdirectory structure. The flat file pattern was being ignored — Felix console showed theTimedata.Rrd4jcomponent in "no config" state despite the file being present in the container.Test plan
./setup.sh— should pass new Step 5 (RRD4j config validation)Timedata.Rrd4jcomponent should beactive(not "no config")meter0/ActiveConsumptionEnergyreturns non-null viagetEdgesChannelsValuesCloses #61
🤖 Generated with Claude Code