Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asgiref tls extension proposal #2586

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

eirikhex
Copy link

@eirikhex eirikhex commented Feb 21, 2025

Summary

Simplification of #1119 according to the discussion in django/asgiref#466
A proof of concept for a change in the asgi spec for the tls extension where
client_cert_name is removed because it's not the role of the ASGI web server to parse X.509 certificate. The content of the field is a part of the client_cert_chain, and should be extracted from there. (as shown in the test in this PR)
client_cert_error is removed as it was impossible to fill with any useful information.
tls_version and cipher_suite is filled with string returned by ssl.SSLSocket.version() and ssl.SSLSocket.cipher()

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@eirikhex eirikhex force-pushed the asgiref-tls-extension-proposal branch from f88f81e to 6da4c0c Compare February 22, 2025 22:28
@eirikhex eirikhex force-pushed the asgiref-tls-extension-proposal branch 7 times, most recently from 87a2dbe to ece9cf9 Compare February 22, 2025 23:13
@eirikhex eirikhex force-pushed the asgiref-tls-extension-proposal branch from ece9cf9 to 78a2f6e Compare February 22, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants