Merge pre-commit workflow into main

[browniebroke]

Description

Both check need to run on the same set of events and can be combined in a single workflow, meaning that we can see the results in a single page. This was initially done in

• Setup release workflow with trusted publisher #9852

But started a discussion showing it deserved its own PR

Since we’ve consolidated pre-commit into main.yml, IMO adding needs: pre-commit to the tests job would be nice. Currently, all jobs will run in parallel, but it would be better to make the tests depend on the pre-commit results to prevent unnecessary runs when there are linting errors.".

Having them run in parallel gives you more feedback when they both fail for different reasons, you can fix both in one go this way. What you're suggesting might have pre-commit hide a problem in tests which you would only discover after fixing the linting error.

I agree with your point here , But I assume people likely do testing of their code before pushing in most scenario, But most of time they forgot to run pre-commit locally. so in such scenario the test jobs will run two times which might be costlier.