Skip to content

Fix validation on many to many field when default=None #9790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 14, 2025
+77 −1
Merged

Fix validation on many to many field when default=None #9790

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7e8962c
Added validation on ManyToMany relations when default=None
Genarito Sep 26, 2025
edaf07b
Added some important notes on contributing.md
Genarito Sep 26, 2025
04703dc
Update tests/test_serializer.py
auvipy Sep 28, 2025
9d8b176
Improved ValueError msg
Genarito Oct 13, 2025
e87a82b
Improved comment on serializer instantiation
Genarito Oct 13, 2025
eb4ed07
Refine error message in ManyToManySourceSerializer test
Genarito Oct 13, 2025
6f29604
Merge branch 'encode:main' into validation-many-to-many
Genarito Oct 14, 2025
9da97c9
Add clarification on `-s` flag usage right after the -q tip
Genarito Oct 14, 2025
542d4dc
Update contributing guidelines to include pytest decorator for databa…
Genarito Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,7 @@ class Meta:
model = ManyToManySource
fields = '__all__'

# Instantiates with invalid data (not value for a ManyToMany field to force using the default)
# Instantiates with invalid data (no value for a ManyToMany field to force using the default)
serializer = ManyToManySourceSerializer(data={
"name": "Invalid Example",
})
Expand Down