Skip to content
Commisery

Update regex matching to handle proper class escaping #4

Sign in to view logs

Update regex matching to handle proper class escaping

Update regex matching to handle proper class escaping #4

Re-run triggered April 6, 2024 18:22
@rjzakrjzak
#19
warthog9:update-regex
Status Failure
Total duration 12s
Artifacts –

commisery.yml

on: pull_request
commit-message  /  commit-message
2s
commit-message / commit-message
Fit to window
Zoom out
Zoom in

Annotations

5 errors
commit-message / commit-message
1 of the pull request's commits are not valid Conventional Commits
(Commit 9954a971) Update regex matching to handle proper class escaping On Python 3.12 it's throwing compile warnings on the regex compiles: ``` spdx/verify-spdx-headers:8: SyntaxWarning: invalid escape sequence '\s' SPDX = re.compile(f'SPDX-License-Identifier:\s+({SLUG.pattern})') spdx/verify-spdx-headers:21: SyntaxWarning: invalid escape sequence '\s' pattern = f"^{init}\s*{SPDX.pattern}\s*{fini}\\s*$" spdx/verify-spdx-headers:21: SyntaxWarning: invalid escape sequence '\s' pattern = f"^{init}\s*{SPDX.pattern}\s*{fini}\s*$" ``` This escapes the the '\s' to be '\\s' instead as that is compliant, seems to compile correctly, and makes the warning go away. Quick checking on my own repos seemed to not break anything. Signed-off-by: John 'Warthog9' Hawley <[email protected]>
[C001] Type tag should be in lower case
(Commit 9954a971) Update regex matching to handle proper class escaping On Python 3.12 it's throwing compile warnings on the regex compiles: ``` spdx/verify-spdx-headers:8: SyntaxWarning: invalid escape sequence '\s' SPDX = re.compile(f'SPDX-License-Identifier:\s+({SLUG.pattern})') spdx/verify-spdx-headers:21: SyntaxWarning: invalid escape sequence '\s' pattern = f"^{init}\s*{SPDX.pattern}\s*{fini}\\s*$" spdx/verify-spdx-headers:21: SyntaxWarning: invalid escape sequence '\s' pattern = f"^{init}\s*{SPDX.pattern}\s*{fini}\s*$" ``` This escapes the the '\s' to be '\\s' instead as that is compliant, seems to compile correctly, and makes the warning go away. Quick checking on my own repos seemed to not break anything. Signed-off-by: John 'Warthog9' Hawley <[email protected]>
[C004] Subject should not contain an unknown tag type. Use one of: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test, improvement
(Commit 9954a971) Update regex matching to handle proper class escaping On Python 3.12 it's throwing compile warnings on the regex compiles: ``` spdx/verify-spdx-headers:8: SyntaxWarning: invalid escape sequence '\s' SPDX = re.compile(f'SPDX-License-Identifier:\s+({SLUG.pattern})') spdx/verify-spdx-headers:21: SyntaxWarning: invalid escape sequence '\s' pattern = f"^{init}\s*{SPDX.pattern}\s*{fini}\\s*$" spdx/verify-spdx-headers:21: SyntaxWarning: invalid escape sequence '\s' pattern = f"^{init}\s*{SPDX.pattern}\s*{fini}\s*$" ``` This escapes the the '\s' to be '\\s' instead as that is compliant, seems to compile correctly, and makes the warning go away. Quick checking on my own repos seemed to not break anything. Signed-off-by: John 'Warthog9' Hawley <[email protected]>
[C005] Zero spaces before and only one space allowed after the ":" separator
(Commit 9954a971) Update regex matching to handle proper class escaping On Python 3.12 it's throwing compile warnings on the regex compiles: ``` spdx/verify-spdx-headers:8: SyntaxWarning: invalid escape sequence '\s' SPDX = re.compile(f'SPDX-License-Identifier:\s+({SLUG.pattern})') spdx/verify-spdx-headers:21: SyntaxWarning: invalid escape sequence '\s' pattern = f"^{init}\s*{SPDX.pattern}\s*{fini}\\s*$" spdx/verify-spdx-headers:21: SyntaxWarning: invalid escape sequence '\s' pattern = f"^{init}\s*{SPDX.pattern}\s*{fini}\s*$" ``` This escapes the the '\s' to be '\\s' instead as that is compliant, seems to compile correctly, and makes the warning go away. Quick checking on my own repos seemed to not break anything. Signed-off-by: John 'Warthog9' Hawley <[email protected]>
[C008] Subject requires a separator (": ") after the type tag