This repository was archived by the owner on Oct 26, 2021. It is now read-only.
Fix x86_64 locked dependency hash #485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Volosatovs <[email protected]>
|
@rvolosatovs Thanks for the patch! I'm hopeful that we'll get a new release of |
|
Closing in favor of #489 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to recent force-push on the upstream PR the existing locked dependency hash became invalid, since the vendored commit is not present in the referenced branch anymore
Fixed the commit hash used in
Cargo.lockto depend on the most recent commit and fix the build.Upstream diff
Note, that it seems that there are more changes expected to the referenced PR - if not based on top of npmccallum/x86_64@4872530, they will break the build again
Perhaps a good idea would be to duplicate the branch and depend on the new branch to avoid the above until the upstream PR is merged and dependency is updated