Skip to content

WRO-10958: Change addon 'object' to 'select' in imageItem sample. #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

WRO-10958: Change addon 'object' to 'select' in imageItem sample. #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/sampler/stories/default/Image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {mergeComponentMetadata} from '@enact/storybook-utils';
import {action} from '@enact/storybook-utils/addons/actions';
import {object, select} from '@enact/storybook-utils/addons/controls';
import {select} from '@enact/storybook-utils/addons/controls';
import Image, {ImageBase, ImageDecorator} from '@enact/sandstone/Image';
import {ImageBase as UiImageBase} from '@enact/ui/Image';

Expand Down Expand Up @@ -48,7 +48,7 @@ export const _Image = (args) => (
</Image>
);

object('src', _Image, Config, src);
select('src', _Image, src, Config, src.hd);
select('sizing', _Image, ['fill', 'fit', 'none'], Config);

_Image.storyName = 'Image';
Expand Down
4 changes: 2 additions & 2 deletions samples/sampler/stories/default/ImageItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {mergeComponentMetadata} from '@enact/storybook-utils';
import {boolean, object, select, text} from '@enact/storybook-utils/addons/controls';
import {boolean, select, text} from '@enact/storybook-utils/addons/controls';
import {ImageItem, ImageItemBase} from '@enact/sandstone/ImageItem';
import {ImageItem as UiImageItem} from '@enact/ui/ImageItem';
import ri from '@enact/ui/resolution';
Expand Down Expand Up @@ -47,7 +47,7 @@ text('label', _ImageItem, Config, 'ImageItem label');
select('orientation', _ImageItem, prop.orientation, Config);
boolean('selected', _ImageItem, Config);
boolean('showSelection', _ImageItem, Config);
object('src', _ImageItem, Config, src);
select('src', _ImageItem, src, Config, src.hd);
select('orientation', _ImageItem, prop.orientation, Config);
text('children', _ImageItem, Config, 'ImageItem Caption');

Expand Down