You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Correct me if I am wrong or you see it differently.
The end-goal would be that empygrad is directly part of empymod, if possible without too much hassle.
The intermediate goal is that one can call, e.g., empymod.model.dipole(..., gradient=True), which will then call internally empygrad, and informs the user about that (and tells the user that empygrad has to be installed if it is not available yet).
The first step, what we are working here, is that we get a minimum diff version btw empygrad and empymod, where empygrad imports everything that is not changed from empymod.
As such, we can remove things like empygrad.scripts, or empygrad.model.gpr etc.
Impossible to say if it installs, runs, works, as there are all just placeholder/dummies atm. I am also not sure about which imports from empymod are necessary and which one could be left out. So I just merge, and you go ahead and continue.
Correct me if I am wrong or you see it differently.
The end-goal would be that empygrad is directly part of empymod, if possible without too much hassle.
The intermediate goal is that one can call, e.g., empymod.model.dipole(..., gradient=True), which will then call internally empygrad, and informs the user about that (and tells the user that empygrad has to be installed if it is not available yet).
The first step, what we are working here, is that we get a minimum diff version btw empygrad and empymod, where empygrad imports everything that is not changed from empymod.
As such, we can remove things like empygrad.scripts, or empygrad.model.gpr etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.