Skip to content

Resistivity - #1

Merged
prisae merged 14 commits into
mainfrom
resistivity
Oct 9, 2026
Merged

prisae merged 14 commits into
mainfrom
resistivity

Conversation

@prisae

@prisae prisae commented Oct 5, 2026

Copy link
Copy Markdown
Member

No description provided.

@prisae

prisae commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

Correct me if I am wrong or you see it differently.

  • The end-goal would be that empygrad is directly part of empymod, if possible without too much hassle.
  • The intermediate goal is that one can call, e.g., empymod.model.dipole(..., gradient=True), which will then call internally empygrad, and informs the user about that (and tells the user that empygrad has to be installed if it is not available yet).
  • The first step, what we are working here, is that we get a minimum diff version btw empygrad and empymod, where empygrad imports everything that is not changed from empymod.

As such, we can remove things like empygrad.scripts, or empygrad.model.gpr etc.

@prisae

prisae commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

Sorry for making you duplicate Report - I removed it again, as I implemented it in
https://github.com/emsig/empymod/pull/256/changes#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33L1311
So when we are ready with empygrad, I will merge that, and from then on empymod will always list empygrad if installed, which also works for empygrad on its own.

@prisae
prisae merged commit 4022c05 into main Oct 9, 2026
1 check failed
@prisae

prisae commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

Impossible to say if it installs, runs, works, as there are all just placeholder/dummies atm. I am also not sure about which imports from empymod are necessary and which one could be left out. So I just merge, and you go ahead and continue.

@WouterDls

Copy link
Copy Markdown
Collaborator

Correct me if I am wrong or you see it differently.

  • The end-goal would be that empygrad is directly part of empymod, if possible without too much hassle.
  • The intermediate goal is that one can call, e.g., empymod.model.dipole(..., gradient=True), which will then call internally empygrad, and informs the user about that (and tells the user that empygrad has to be installed if it is not available yet).
  • The first step, what we are working here, is that we get a minimum diff version btw empygrad and empymod, where empygrad imports everything that is not changed from empymod.

As such, we can remove things like empygrad.scripts, or empygrad.model.gpr etc.

Totally agree!

@WouterDls
WouterDls deleted the resistivity branch October 13, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants