Make emsdk a proper Python package #1043
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR turns this repo into a proper Python package which installs the emsdk script as a Python entry point, meaning that
pip install emsdk
will make theemsdk
script discoverable in the path.It also allows other Python packages to depend on emsdk and use it from Python.
Motivation
The motivation behind this PR is to make a
conda-forge
package for emsdk, allowing people to install emsdk with conda:You can also publish it on PyPi if you want, but that's not mandatory.
Other comments
I am opening this PR as draft and hoping to get some feedback from the emscripten devs on this before pushing more on the PR (updating the CI so that it tests the Python installed emsdk).
I did my best to not change your usage of emsdk
I had to move some scripts, JSON and txt files under the emsdkpy Python package, otherwise setuptools would not install them as part of the Python package.