[rebaseline_tests] Improve commit message for --bump-emsdk. NFC#27318
Merged
Conversation
sbc100
force-pushed
the
fix_emsdk_bump_formatting
branch
3 times, most recently
from
3c17125 to
0ab8405
Compare
sbc100
changed the title
Improve the commit message generated by `rebaseline_tests.py` when running with `--bump-emsdk`: - Pass `old_sha` and `new_sha` (`current_sha` and `installed_sha`) directly to `format_emsdk_version_update()`, rather than reading from disk or querying `git show HEAD:test/emsdk_version.txt`. - Format the list of included emsdk revisions as a markdown list inside a block quote so that automated roll PRs are easier to read on GitHub. - Clearly separate the full revision log URL at the bottom of the message.
sbc100
force-pushed
the
fix_emsdk_bump_formatting
branch
from
0ab8405 to
d5df10c
Compare
dschuff
approved these changes
Jul 11, 2026
| @@ -1 +1 @@ | |||
| 9a93926b6aca0b3ce87539c7ff208d3242aa0731 | |||
Member
There was a problem hiding this comment.
maybe the actual bump here should be separate
This is an automatic change generated by tools/maint/rebaseline_tests.py --bump-emsdk. emsdk version updated: 9a93926b6aca0b3ce87539c7ff208d3242aa0731 => 5b6cadd24c975a9ba541c7722a7205b37b39f246 This includes the following revisions: ''' - 5b6cadd2 Roll binaryen from 69d28ed6b8b1 to 21822346a32c (1 revision) - 759f0d3a Roll llvm-project from 9a1fe8e03c04 to 7c35673039cf (49 revisions) - 3f30c310 Roll emscripten from f3c99c9 to 35e6e0e (1 revision) - fe5ca712 Roll llvm-project from 642b85388cca to 9a1fe8e03c04 (34 revisions) - 67938583 Roll llvm-project from d0339aef5f46 to 642b85388cca (36 revisions) - 6c5be1d0 Roll llvm-project from 880f3d0fbe32 to d0339aef5f46 (19 revisions) - 686fe269 Roll emscripten from d7ab361 to f3c99c9 (3 revisions) - a98a0d71 Roll llvm-project from bba373c7a20c to 880f3d0fbe32 (40 revisions) - 3ec21a0d Roll emscripten from 4237a12 to d7ab361 (5 revisions) - e6e60eaa Roll binaryen from 21a717e8e8b3 to 69d28ed6b8b1 (1 revision) - d5ca2c05 Roll v8 from 474e5320ea63 to f77acb421fea (41 revisions) - b36d433a Roll emscripten from 4627e65 to 4237a12 (2 revisions) ''' Full log: https://chromium.googlesource.com/emscripten-releases/+log/9a93926b6aca0b3ce87539c7ff208d3242aa0731..5b6cadd24c975a9ba541c7722a7205b37b39f246
sbc100
force-pushed
the
fix_emsdk_bump_formatting
branch
from
e52d078 to
8ce4631
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the commit message generated by
rebaseline_tests.pywhenrunning with
--bump-emsdk:old_shaandnew_sha(current_shaandinstalled_sha)directly to
format_emsdk_version_update(), rather than reading fromdisk or querying
git show HEAD:test/emsdk_version.txt.a block quote so that automated roll PRs are easier to read on GitHub.
message.