Use Promise internally for handling run dependencies. NFC#27171
Open
sbc100 wants to merge 1 commit into
Open
Conversation
sbc100
changed the title
sbc100
force-pushed
the
resolveRunDependencies
branch
2 times, most recently
from
24bd80b to
d8b705b
Compare
This is a logical followup to emscripten-core#27121, and comes with a codesize saving in many cases. Add `$resolveRunDependencies` to allow awaiting the resolution of all active run dependencies. This is useful for async runtime operations like `emscripten_async_load_script` which need to wait for loaded scripts to finish their own async setup (e.g. file preloading) before triggering their onload callbacks. Codesize impact: - test_codesize_file_preload: -19 bytes (JS) - test_codesize_hello_dylink_all: +40 bytes (JS) - All other tests (including C++ tests): 0 bytes change (fully DCE'd)
sbc100
force-pushed
the
resolveRunDependencies
branch
from
d8b705b to
117db0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a logical followup to #27121, and comes with a codesize saving in many cases.
Add
$resolveRunDependenciesto allow awaiting the resolution of all active run dependencies. This is useful for async runtime operations likeemscripten_async_load_scriptwhich need to wait for loaded scripts to finish their own async setup (e.g. file preloading) before triggering their onload callbacks.Codesize impact: