Skip to content

[pylauncher] Pass -X utf8 to python when using -E#27169

Merged
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:port-pylauncher-utf8
Jun 23, 2026
Merged

[pylauncher] Pass -X utf8 to python when using -E#27169
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:port-pylauncher-utf8

Conversation

@sbc100

@sbc100 sbc100 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Port the fix from a2bfe33 to pylauncher.c. This prevents the Python codepage from reverting from unicode to cp1252 on Windows when stdout/stderr is redirected.

See: #26972

Port the fix from a2bfe33 to pylauncher.c. This prevents the
Python codepage from reverting from unicode to cp1252 on Windows
when stdout/stderr is redirected.

See: emscripten-core#26972
@sbc100 sbc100 requested a review from juj June 23, 2026 22:32
@sbc100

sbc100 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

@juj, I assume the fix in #26972, is needed not just in the .bat file case?

@sbc100 sbc100 requested a review from dschuff June 23, 2026 22:33
@sbc100 sbc100 merged commit 4177187 into emscripten-core:main Jun 23, 2026
31 of 39 checks passed
@sbc100 sbc100 deleted the port-pylauncher-utf8 branch June 23, 2026 23:17
sbc100 added a commit to sbc100/emscripten that referenced this pull request Jun 30, 2026
This executable was pulled from the latest win32 build on the
emscripten-releases waterfall:

https://storage.googleapis.com/webassembly/emscripten-releases-builds/win/2650e4f60d08b155fbe8b01140ea1e8527cb55ac/wasm-binaries.zip

This includes emscripten-core#27169, which I confirmed by running `strings -l` on
the binary before and after.
@sbc100 sbc100 mentioned this pull request Jun 30, 2026
sbc100 added a commit that referenced this pull request Jul 1, 2026
This executable was pulled from the latest win32 build on the
emscripten-releases waterfall:

https://storage.googleapis.com/webassembly/emscripten-releases-builds/win/2650e4f60d08b155fbe8b01140ea1e8527cb55ac/wasm-binaries.zip

This includes #27169, which I confirmed by running `strings -l` on the
binary before and after.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants