Skip to content

Re-enable test_eval_ctors_no_main under wasm64. NFC #26960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 2 commits into from
May 15, 2026
Merged

Re-enable test_eval_ctors_no_main under wasm64. NFC #26960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
683016e
Re-enable test_eval_ctors_no_main under wasm64. NFC
sbc100 May 15, 2026
eeca762
Update test/test_core.py
sbc100 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1732,10 +1732,9 @@ def test_ctors_no_main(self):

@no_wasm2js('eval_ctors not supported yet')
@no_2gb('https://github.com/WebAssembly/binaryen/issues/5893')
@no_4gb('https://github.com/WebAssembly/binaryen/issues/5893')
@also_with_standalone_wasm(impure=True)
def test_eval_ctors_no_main(self):
if self.get_setting('MEMORY64') == 1:
self.skipTest('https://github.com/WebAssembly/binaryen/issues/5017')
self.set_setting('EVAL_CTORS')
self.do_core_test('test_ctors_no_main.cpp', cflags=['--no-entry'])

Expand Down Expand Up @@ -9938,6 +9937,8 @@ def setUp(self):
# MEMORY64=1
wasm64 = make_run('wasm64', cflags=['--profiling-funcs'],
settings={'MEMORY64': 1}, require_wasm64=True)
wasm64_O2 = make_run('wasm64_O2', cflags=['-O2'],
settings={'MEMORY64': 1}, require_wasm64=True)
# Run the wasm64 tests with all memory offsets > 4gb. Be careful running this test
# suite with any kind of parallelism.
wasm64_4gb = make_run('wasm64_4gb', cflags=['--profiling-funcs'],
Expand Down
Loading