Skip to content

Run test_wasm_worker_futex_wait also in hybrid mode. NFC#26827

Merged
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:futex_wait_pthread_wasm_workers
May 4, 2026
Merged

Run test_wasm_worker_futex_wait also in hybrid mode. NFC#26827
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:futex_wait_pthread_wasm_workers

Conversation

@sbc100

@sbc100 sbc100 commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@sbc100 sbc100 requested a review from kripken April 30, 2026 18:01

@kripken kripken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comment

Comment thread test/test_core.py Outdated
@sbc100 sbc100 force-pushed the futex_wait_pthread_wasm_workers branch from c8f3359 to bbd207c Compare April 30, 2026 18:42
@sbc100 sbc100 enabled auto-merge (squash) April 30, 2026 18:42
@sbc100 sbc100 force-pushed the futex_wait_pthread_wasm_workers branch 2 times, most recently from 557f2cd to 288bac7 Compare April 30, 2026 19:38
@sbc100

sbc100 commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator Author

Let me know if you want to split out the decorator move/expand as an NFC

@sbc100 sbc100 force-pushed the futex_wait_pthread_wasm_workers branch from 288bac7 to 83d6291 Compare April 30, 2026 20:19
Comment thread test/decorators.py Outdated

@kripken kripken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % question

@sbc100 sbc100 force-pushed the futex_wait_pthread_wasm_workers branch from 83d6291 to 818686b Compare May 4, 2026 01:11
sbc100 added a commit to sbc100/emscripten that referenced this pull request May 4, 2026
This decorator now also delegates to `require_pthreads()` helper method.

Split out from emscripten-core#26827
@sbc100 sbc100 force-pushed the futex_wait_pthread_wasm_workers branch from 818686b to fa2774d Compare May 4, 2026 01:16
@sbc100

sbc100 commented May 4, 2026

Copy link
Copy Markdown
Collaborator Author

I split out the test decorator changes into separate change #26843

sbc100 added a commit that referenced this pull request May 4, 2026
This decorator now also delegates to `require_pthreads()` helper method.

Split out from #26827
@sbc100 sbc100 disabled auto-merge May 4, 2026 05:03
@sbc100 sbc100 force-pushed the futex_wait_pthread_wasm_workers branch from fa2774d to b7eeb3c Compare May 4, 2026 05:04
@sbc100 sbc100 merged commit f92e9e1 into emscripten-core:main May 4, 2026
4 of 15 checks passed
@sbc100 sbc100 deleted the futex_wait_pthread_wasm_workers branch May 4, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants