Use consistent message (done) to signal test success. NFC#26824
Merged
Conversation
sbc100
force-pushed
the
consistent_done
branch
2 times, most recently
from
c3a1735 to
d3ee78f
Compare
We had some tests using `done` and others using `success`, and since `done` was more popular I decided to standardize on that. As a followup, I think we can perhaps make this the default for the `do_runf` method which will simplify things further.
kripken
approved these changes
Apr 30, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 12, 2026
sbc100
added a commit
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some tests using
doneand others usingsuccess, and sincedonewas more popular I decided to standardize on that.As a followup, I think we can perhaps make this the default for the
do_runfmethod which will simplify things further.