Fix for emrun --kill-exit #25703
Merged
Fix for emrun --kill-exit #25703
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken by emscripten-core#25359. I though I was just moving this assignment to the correct place, but it seems like it broken emrun because the 1.1 protocol was not actually enabled before. Once enabled it seems like this was causing `httpd.server_close` to hang forever. Fixes: emscripten-core#25654
|
Is |
juj
approved these changes
Nov 3, 2025
|
Would be good to have a test of the failing cmdline if possible. I think we had emrun tests in the other suite? |
|
I think that our emrun tests are currently disabled.. we should certainly re-enable. When we do I will try to confirm if there is already a test for this, and if not I will add one. |
Its upstream. However I guess that point at which is it read means that out previous usage of it was not effectual When I I fixed that, the 1.1 starting having and effect which then broke emrun due to the open connection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by #25359. I though I was just moving this assignment to the correct place, but it seems like it broken emrun because the 1.1 protocol was not actually enabled before. Once enabled it seems like this was causing
httpd.server_closeto hang forever.Fixes: #25654