-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Adds SDL3_image port #24634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adds SDL3_image port #24634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks generally good.
Removes duplicated tests that are already done in SDL2 (wasmfs, sjlj & co) Co-authored-by: Alon Zakai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but is this still marked as draft because you have more work to do?
Code size test failures should be fixed by merging in latest The documentation test error should be fixable by the command mentioned in the error, |
Oh, please add a changelog mention here too, as in the other PR. Thanks, it's great to get these added! |
That's right, wanted to fix the failing doctest first -- will do that asap, thank you :) |
No description provided.