Remove node canary test decorators. NFC #24478
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_node_canary_test
branch
2 times, most recently
from
a9b53bb to
b0de9bc
Compare
kripken
reviewed
Jun 3, 2025
| @@ -524,15 +524,15 @@ jobs: | |||
| test-core0: | |||
| executor: focal | |||
| environment: | |||
| EMTEST_SKIP_NODE_CANARY: "1" | |||
| EMTEST_SKIP_NODE24: "1" | |||
There was a problem hiding this comment.
Perhaps 24 => latest or such, so we can update it without changing all these places?
There was a problem hiding this comment.
The problem is that we don't want tests marked as require_node_version(24) to be disabled by EMTEST_SKIP_NODE_LATEST once latest becomes 25 or 26.
Unless you think we should also replace require_node_version(24) with just require_node_latest?
The approach here seems to me like the least complicated approach for now. We can revisit later.
There was a problem hiding this comment.
Fair enough, this does seem simple for now.
sbc100
force-pushed
the
remove_node_canary_test
branch
from
b0de9bc to
86c776e
Compare
All these features actually work on the official node 24 these days.
sbc100
force-pushed
the
remove_node_canary_test
branch
from
86c776e to
bcde837
Compare
kripken
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these features actually work on the official node 24 these days.