Skip to content

Improve MainModuleFactory type emitted by create_tsd #24087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −5
Open

Improve MainModuleFactory type emitted by create_tsd #24087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7580592
Improve MainModuleFactory type emitted by create_tsd
s-h-a-d-o-w Apr 10, 2025
9485ed5
update test expectation
sbc100 Apr 10, 2025
73e5ce8
oops
sbc100 Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/other/embind_tsgen_ignore_2.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,4 +151,4 @@ interface EmbindModule {
}

export type MainModule = WasmModule & EmbindModule;
export default function MainModuleFactory (options?: unknown): Promise<MainModule>;
export default function MainModuleFactory (moduleOverrides?: Partial<MainModule>): Promise<MainModule>;
2 changes: 1 addition & 1 deletion test/other/embind_tsgen_module.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,4 +152,4 @@ interface EmbindModule {
}

export type MainModule = WasmModule & EmbindModule;
export default function MainModuleFactory (options?: unknown): Promise<MainModule>;
export default function MainModuleFactory (moduleOverrides?: Partial<MainModule>): Promise<MainModule>;
2 changes: 1 addition & 1 deletion test/other/test_emit_tsd.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ interface WasmModule {
}

export type MainModule = WasmModule & typeof RuntimeExports;
export default function MainModuleFactory (options?: unknown): Promise<MainModule>;
export default function MainModuleFactory (moduleOverrides?: Partial<MainModule>): Promise<MainModule>;
2 changes: 1 addition & 1 deletion test/other/test_emit_tsd_sync.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ interface WasmModule {
}

export type MainModule = WasmModule;
export default function MainModuleFactory (options?: unknown): MainModule;
export default function MainModuleFactory (moduleOverrides?: Partial<MainModule>): MainModule;
2 changes: 1 addition & 1 deletion tools/emscripten.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ def create_tsd(metadata, embind_tsd):
return_type = 'MainModule'
if settings.WASM_ASYNC_COMPILATION:
return_type = f'Promise<{return_type}>'
out += f'export default function MainModuleFactory (options?: unknown): {return_type};\n'
out += f'export default function MainModuleFactory (moduleOverrides?: Partial<MainModule>): {return_type};\n'
return out


Expand Down