Move emscripten_atomics_is_lock_free to atomic.h. NFC
#23778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is generally useful for either pthreads or wasm worker builds. Putting it in `atomic.h` and `libatomic.js` make sense. Also remove the duplicate `emscripten_navigator_hardware_concurrency` function which duplicates the existing `emscripten_num_logical_cores`. Also, change the return type of `emscripten_atomics_is_lock_free` to be `bool`, which better represents its type.
kripken
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is generally useful for either pthreads or wasm worker builds. Putting it in
atomic.handlibatomic.jsmake sense.Also remove the duplicate
emscripten_navigator_hardware_concurrencyfunction which duplicates the existingemscripten_num_logical_cores.Also, change the return type of
emscripten_atomics_is_lock_freeto bebool, which better represents its type.