Handle canvas framebuffer scaling. #19844
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where
glfwGetWindowSize
andglfwGetFramebufferSize
were incorrectly reporting the same values, despite the fact that the canvas native and normal dimensions were different. The proposed map is as follows:glfwGetFramebufferSize()
->Module.canvas.[width, height]
glfwGetWindowSize()
->Module.canvas.[widthNative, heightNative]
This also scales the values returned from
getCursorPos
.I thought about automatically resizing the canvas frame buffer size (
canvas.[width, height]
) according to theglfwGetMonitorContentScale
but I imagine this would break a lot of software. The way I implemented this PR only makes a difference when the canvas frame buffer size is manually altered.Fixes #19842 (?)