Repository navigation
fix: isolate unsupported column types during schema discovery - #33
Merged
Merged
Conversation
Skip unused unsupported columns in row inserts and restrict schema inference to confirmed missing tables. Add real-database regression coverage for writes and error propagation.
5 tasks
Use general schema and test names, and document unsupported-column isolation and explicit NULL rejection.
hjianbo
marked this pull request as ready for review
October 21, 2026 08:18
hjianbo
requested review from
JimMoen
and
a balanced review from Copilot
and removed request for
Copilot
October 21, 2026 10:04
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
zmstone
reviewed
Oct 22, 2026
Preserve raw gRPC table names across metadata lookups and escape SQL identifiers. Cover existing and auto-created special names, mixed-row defaults, and authentication error propagation against GreptimeDB.
zmstone
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row inserts currently discard the server schema when any column has an unsupported type, even if that column is omitted from the input. Falling back to inference loses the declared types of supported columns. For example, a table containing both JSON2 and DECIMAL rejects an ordinary JSON binary because it is inferred as STRING.
Separate supported schema columns from unsupported column metadata. Supported columns retain their server-declared types, independently of unrelated unsupported columns. This applies to all supported types; JSON2 is one regression case.
nilorundefined, rejects the whole batch before sending it. Omitting a field is distinct from requesting SQL NULL.TableNotFounderror (4001) permits local inference. Other schema-query and decoding errors are returned directly.Validation against real GreptimeDB v1.2.1 on OTP 27:
SHOW CREATE TABLE, and server rejection of invalid names containing double quotes.nilrejection was compared with the old inference path, which silently omitted that field and applied its default.cargo check, CI clippy flags, TOML formatting and cargo-deny checks passed.Extra input-column scanning is limited to tables with unsupported types.
Type codec and query-result coverage gaps (including DECIMAL and VECTOR) are tracked separately in #34 and remain outside this PR.