Allow all LLVM versions >= 15 and support dynamic linking #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuxnot
force-pushed
the
feature/support-dynamic-linking
branch
from
59bd92d to
1d11e19
Compare
Closed
stuxnot
force-pushed
the
feature/support-dynamic-linking
branch
6 times, most recently
from
bf12078 to
bc045ad
Compare
stuxnot
changed the title
|
This is currently blocked by the github ci runners not supporting llvm 18 for some reason. Will have to investigate further. |
stuxnot
changed the title
Closed
stuxnot
force-pushed
the
feature/support-dynamic-linking
branch
3 times, most recently
from
6085386 to
473b681
Compare
stuxnot
force-pushed
the
feature/support-dynamic-linking
branch
10 times, most recently
from
0f1bc42 to
3805334
Compare
Use LLVM version 18 in all build scripts, since it is fully compatible with the existing LLVM 15 code.
stuxnot
force-pushed
the
feature/support-dynamic-linking
branch
from
3805334 to
139b8e2
Compare
stuxnot
force-pushed
the
feature/support-dynamic-linking
branch
from
139b8e2 to
014cfd1
Compare
|
Since the github linux runners do not support llvm > 15 for some |
stuxnot
changed the title
Closed
pkoppe
reviewed
Oct 31, 2024
pkoppe
reviewed
Oct 31, 2024
pkoppe
reviewed
Oct 31, 2024
pkoppe
reviewed
Oct 31, 2024
pkoppe
reviewed
Oct 31, 2024
pkoppe
reviewed
Oct 31, 2024
pkoppe
reviewed
Oct 31, 2024
pkoppe
reviewed
Oct 31, 2024
pkoppe
reviewed
Oct 31, 2024
pkoppe
reviewed
Oct 31, 2024
stuxnot
force-pushed
the
feature/support-dynamic-linking
branch
2 times, most recently
from
ec10f8a to
64e2261
Compare
stuxnot
force-pushed
the
feature/support-dynamic-linking
branch
from
64e2261 to
2327bcf
Compare
pkoppe
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses more of llvm-sys build.rs to support dynamic linking when static linking is not supported. Additionally, adds the
NYXSTONE_LINK_FFIflag, which tells nyxstone thatlibffishould be linked. This is necessary as LLVM sometimes might be linked againstlibffibut not report this fact viallvm-config.Furthermore adds changes to the python
setup.pyto support dynamic linking in python, when static linking is not supported.