Issue/2 #4
Open
Issue/2 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed that findMediaBreakpoints was not working. Worked through the issue, honestly don't remember exactly which bit fixes things. Also updated package.json for my own use. Also extracted findBreakpoints from external project into this one because I just wanted things working. Could make the same/similar changes to the external project but for the purpose of just making this extension do the thing right, I'm leaving it as is.
Add 8.10.0 as engine as that's the version I found that works. 10.x was no good, neither was 12.x Add self-contributor so that people can get in touch Sort run scripts
|
Thanks for the contribution, but I’m not sure how this fixes the original problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Fixed Breakpoint detection by inlining the find breakpoint script and working through the issue(s).
Seems to be working well enough, if anyone needs a copy I've left an unsigned
crxin the releases on the fork.